Skip to main content

performance tuning - Is there any way to speed up this code that's Maximizing a function got from numerical integration?


I have this code below, which is calculating the Binding energy of an electron in a Quantum Well Wire with a hydrogenic impurity in it. Well you don't have to care much about what kind of calculation it does, because it is returning the right number, my only problem is, that it's taking about 20 minutes for it to return a single value for the Eb function (you can try Eb[0.7, 1, 0.01]). I'm wondering, if there's a way to make this code run faster. As you can see I have written everything almost the same way as one would write on paper. I've searched and tried many different approaches to make it faster, but nothing has helped so far.


e = 4.803*10^-10;
m = 0.067*9.109*10^-28;
h = 1.054*10^-27;
c = 2.997*10^10;
e0 = 13.18;


O1[Om_] = 10^13*Om;

oH[h0_] = (e*10000*h0)/(m*c);

Oc[h0_, Om_] = Sqrt[oH[h0]^2 + 4*O1[Om]^2];

aH[h0_, Om_] = Sqrt[h/(m*Oc[h0, Om])];

r0[rho_, phi_, z_, rhoi_] =
Sqrt[rho^2 + rhoi^2 - 2*rho*rhoi*Cos[phi] + z^2];


Psi[rho_, h0_, Om_] = E^(-(1/2)*(rho^2*aH[1, Om]^2)/aH[h0, Om]^2);

MGamma[rho_, phi_, z_, rhoi_, lambda_, Om_] =
E^(-lambda*r0[rho, phi, z, rhoi]);

CPhi[rho_, phi_, z_, rhoi_, lambda_, h0_, Om_] =
Psi[rho, h0, Om]*MGamma[rho, phi, z, rhoi, lambda, Om];

intCPhiCPhi[rhoi_, lambda_, h0_, Om_] :=

NIntegrate[
Abs[CPhi[rho, phi, z, rhoi, lambda, h0, Om]]^2*rho, {rho, 0,
Infinity}, {phi, 0, 2*\[Pi]}, {z, -Infinity, +Infinity}];

leftover[rho_, phi_, z_, rhoi_, lambda_, h0_, Om_] =
CPhi[rho, phi, z, rhoi, lambda, h0, Om]*
h^2/(2*m*(aH[1, Om])^2)*(Psi[rho, h0, Om]/rho*
D[MGamma[rho, phi, z, rhoi, lambda, Om], rho] +
2*D[MGamma[rho, phi, z, rhoi, lambda, Om], rho]*
D[Psi[rho, h0, Om], rho] +

Psi[rho, h0, Om]*
D[MGamma[rho, phi, z, rhoi, lambda, Om], {rho, 2}] +
Psi[rho, h0, Om]/rho^2*
D[MGamma[rho, phi, z, rhoi, lambda, Om], +{phi, 2}] +
Psi[rho, h0, Om]*
D[MGamma[rho, phi, z, rhoi, lambda, Om], {z, 2}]) + (e^2*
Abs[CPhi[rho, phi, z, rhoi, lambda, h0, Om]]^2)/(e0*
r0[rho, phi, z, rhoi]*aH[1, Om]);

IntLeftover[rhoi_?NumericQ, lambda_?NumericQ, h0_?NumericQ,

Om_?NumericQ] := (2*e0^2*h^2)/(e^4*
m)*((1/intCPhiCPhi[rhoi, lambda, h0, Om] )*
NIntegrate[
leftover[rho, phi, z, rhoi, lambda, h0, Om]*rho, {rho, 0,
Infinity}, {phi, 0, 2*\[Pi]}, {z, -Infinity, +Infinity}])

Eb[rhoi_, h0_, Om_] :=
FindMaximum[IntLeftover[rhoi, lambda, h0, Om], lambda];

Answer



One way to speed up multidimensional integrals is to reduce the PrecisionGoal. That will be acceptable in some cases but not in others.



Modified OP's code:


Clear[e, m, h, c, e0]  (* I moved the parameter initialization to later (unimportant *)

O1[Om_] = 10^13*Om;
oH[h0_] = (e*10000*h0)/(m*c);
Oc[h0_, Om_] = Sqrt[oH[h0]^2 + 4*O1[Om]^2];
aH[h0_, Om_] = Sqrt[h/(m*Oc[h0, Om])];
r0[rho_, phi_, z_, rhoi_] = Sqrt[rho^2 + rhoi^2 - 2*rho*rhoi*Cos[phi] + z^2];
Psi[rho_, h0_, Om_] = E^(-(1/2)*(rho^2*aH[1, Om]^2)/aH[h0, Om]^2);
MGamma[rho_, phi_, z_, rhoi_, lambda_, Om_] = E^(-lambda*r0[rho, phi, z, rhoi]);

CPhi[rho_, phi_, z_, rhoi_, lambda_, h0_, Om_] =
Psi[rho, h0, Om]*MGamma[rho, phi, z, rhoi, lambda, Om];

intCPhiCPhi[rhoi_, lambda_, h0_, Om_] :=
NIntegrate[Abs[CPhi[rho, phi, z, rhoi, lambda, h0, Om]]^2*rho, (* NB: Abs[..]^2=(..)^2 *)
{phi, 0, 2*Ï€}, {rho, 0, Infinity}, {z, -Infinity, +Infinity},
PrecisionGoal -> 3];

leftover[rho_, phi_, z_, rhoi_, lambda_, h0_, Om_] =
CPhi[rho, phi, z, rhoi, lambda, h0, Om]*

h^2/(2*m*(aH[1, Om])^2)*(Psi[rho, h0, Om]/rho*
D[MGamma[rho, phi, z, rhoi, lambda, Om], rho] +
2*D[MGamma[rho, phi, z, rhoi, lambda, Om], rho]*D[Psi[rho, h0, Om], rho] +
Psi[rho, h0, Om]*D[MGamma[rho, phi, z, rhoi, lambda, Om], {rho, 2}] +
Psi[rho, h0, Om]/rho^2*D[MGamma[rho, phi, z, rhoi, lambda, Om], +{phi, 2}] +
Psi[rho, h0, Om]*D[MGamma[rho, phi, z, rhoi, lambda, Om], {z, 2}]) +
(e^2*Abs[CPhi[rho, phi, z, rhoi, lambda, h0, Om]]^2) /
(e0*r0[rho, phi, z, rhoi]*aH[1, Om]);

IntLeftover[rhoi_?NumericQ, lambda_?NumericQ, h0_?NumericQ,

Om_?NumericQ] := (2*e0^2*h^2)/(e^4*
m)*((1/intCPhiCPhi[rhoi, lambda, h0, Om])*
NIntegrate[leftover[rho, phi, z, rhoi, lambda, h0, Om]*rho,
{phi, 0, 2*Ï€}, {rho, 0, Infinity}, {z, -Infinity, +Infinity},
PrecisionGoal -> 3]);

Eb[rhoi_, h0_, Om_] := FindMaximum[IntLeftover[rhoi, lambda, h0, Om], lambda];

OP's example:


PrintTemporary@Dynamic@Clock@{0, Infinity};  (* running timer (helps preserve my sanity *)

Block[{ (* parameter initialization *)
e = 4.803*10^-10,
m = 0.067*9.109*10^-28,
h = 1.054*10^-27,
c = 2.997*10^10,
e0 = 13.18},
Eb[0.7, 1, 0.01] // AbsoluteTiming
]



FindMaximum::lstol: The line search decreased the step size to within the tolerance specified by AccuracyGoal and PrecisionGoal but was unable to find a sufficient increase in the function. You may need more than MachinePrecision digits of working precision to meet these tolerances.



(*  {11.0647, {1.16175, {lambda -> 2.28525}}}  *)

Playing with it, I sometimes did not get a FindMaximum::lstol warning, but I always got 2.28525 or 2.28526 for an answer. I suspect that the noise from the numerical integration is the source.


Comments

Popular posts from this blog

plotting - How to draw lines between specified dots on ListPlot?

I would like to create a plot where I have unconnected dots and some connected. So far, I have figured out how to draw the dots. My code is the following: ListPlot[{{1, 1}, {2, 2}, {3, 3}, {4, 4}, {1, 4}, {2, 5}, {3, 6}, {4, 7}, {1, 7}, {2, 8}, {3, 9}, {4, 10}, {1, 10}, {2, 11}, {3, 12}, {4,13}, {2.5, 7}}, Ticks -> {{1, 2, 3, 4}, None}, AxesStyle -> Thin, TicksStyle -> Directive[Black, Bold, 12], Mesh -> Full] I have thought using ListLinePlot command, but I don't know how to specify to the command to draw only selected lines between the dots. Do have any suggestions/hints on how to do that? Thank you. Answer One possibility would be to use Epilog with Line : ListPlot[ {{1, 1}, {2, 2}, {3, 3}, {4, 4}, {1, 4}, {2, 5}, {3, 6}, {4, 7}, {1, 7}, {2, 8}, {3, 9}, {4, 10}, {1, 10}, {2, 11}, {3, 12}, {4, 13}, {2.5, 7}}, Ticks -> {{1, 2, 3, 4}, None}, AxesStyle -> Thin, TicksStyle -> Directive[Black, Bold, 12], Mesh -> Full, Epilog -> { Line[ ...

equation solving - Invert and fit implicitly defined curve

I need to fit an implicitly defined curve. I thought I could get some data out of Solve , and then using FindFit . Therefore, I would like to find the relation the parametric curve defined by $F(x,y)=0$: Solve[-(1/2) + 1/2 (0.41202 BesselK[0, 0.1 Sqrt[x^2 + y^2]] + (0.101483 x BesselK[1, 0.1 Sqrt[x^2 + y^2]])/Sqrt[x^2 + y^2]) == 0, y] But I can't get an output: Solve was unable to solve the system with inexact coefficients or the system obtained by direct rationalization of inexact numbers present in the system. Since many of the methods used by Solve require exact input, providing Solve with an exact version of the system may help. >> Edit: In particular, I would like to fit the data coming from the curve with the expression of another curve, and not with a function $f(x)$. In particular, since this clearly looks like a cardioid , I would like it to fit to something like it. What other strategies could I try?

dynamic - How can I make a clickable ArrayPlot that returns input?

I would like to create a dynamic ArrayPlot so that the rectangles, when clicked, provide the input. Can I use ArrayPlot for this? Or is there something else I should have to use? Answer ArrayPlot is much more than just a simple array like Grid : it represents a ranged 2D dataset, and its visualization can be finetuned by options like DataReversed and DataRange . These features make it quite complicated to reproduce the same layout and order with Grid . Here I offer AnnotatedArrayPlot which comes in handy when your dataset is more than just a flat 2D array. The dynamic interface allows highlighting individual cells and possibly interacting with them. AnnotatedArrayPlot works the same way as ArrayPlot and accepts the same options plus Enabled , HighlightCoordinates , HighlightStyle and HighlightElementFunction . data = {{Missing["HasSomeMoreData"], GrayLevel[ 1], {RGBColor[0, 1, 1], RGBColor[0, 0, 1], GrayLevel[1]}, RGBColor[0, 1, 0]}, {GrayLevel[0], GrayLevel...