Skip to main content

function construction - Error computing sum of sum of digits



I've defined a function that computes the sum of the base-b digits of n:


DigitSum[n_, b_] := Total[IntegerDigits[n, b]]

Then I defined a function that computes the sum of the base-b digits of all of the integers up to x:


CumDigitSum[x_, b_] := Sum[DigitSum[n, b], {n, 1, x}]

Using these functions, I get


CumDigitSum[1000000,10]=27000001

which is correct. But then for larger inputs I get nonsense like



CumDigitSum[1000001,10]=500011500011

If I work in a different base, the same thing happens: at exactly 1000001, Mathematica begins computing the sum incorrectly. If I bypass my user-defined functions and just write what I mean, I get the correct answer:


Sum[Total[IntegerDigits[n, 10]], {n, 1, 1000001}] = 27000003

Any idea what could be happening here?



Answer



If you wish to compute the correct values using the method you have chosen you could specify Method -> "Procedural" for Sum:


CumDigitSum[x_, b_] := Sum[DigitSum[n, b], {n, 1, x}, Method -> "Procedural"]


CumDigitSum[1000001, 10]


27000003

However, the problem comes form the fact that Sum attempts to speed the calculation by finding a symbolic equivalent. Let's see what your DigitSum returns with symbolic input:


DigitSum[n, b]


b + n


That's clearly not correct generally! Why does this happen? Mathematica functions often work on arbitrary expressions as well as lists, and that is the case with Total. First the IntegerDigits call remain unevaluated:


IntegerDigits[n, b]


IntegerDigits[n, b]

But then Total adds its arguments as though this were {n, b}:


IntegerDigits[n, b] // Total



b + n

To prevent this you can add a Condition or PatternTest as belisarius recommended in a comment above:


DigitSum[n_?NumericQ, b_] := Total[IntegerDigits[n, b]]

This will block Sum form finding a (false) symbolic equivalent thereby forcing it to use a procedural evaluation, even with your original CumDigitSum definition.


For this particular case it is somewhat cleaner to use Tr in place of Total as it will not sum the arguments of an arbitrary expression:


Tr[IntegerDigits[n, b]]



Tr[IntegerDigits[n, b]]

Therefore:


DigitSum[n_, b_] := Tr[IntegerDigits[n, b]]

By the way, it is not recommended to start user Symbol names with capital letters as these can conflict with built-in functions, now or later.


Comments

Post a Comment

Popular posts from this blog

front end - keyboard shortcut to invoke Insert new matrix

I frequently need to type in some matrices, and the menu command Insert > Table/Matrix > New... allows matrices with lines drawn between columns and rows, which is very helpful. I would like to make a keyboard shortcut for it, but cannot find the relevant frontend token command (4209405) for it. Since the FullForm[] and InputForm[] of matrices with lines drawn between rows and columns is the same as those without lines, it's hard to do this via 3rd party system-wide text expanders (e.g. autohotkey or atext on mac). How does one assign a keyboard shortcut for the menu item Insert > Table/Matrix > New... , preferably using only mathematica? Thanks! Answer In the MenuSetup.tr (for linux located in the $InstallationDirectory/SystemFiles/FrontEnd/TextResources/X/ directory), I changed the line MenuItem["&New...", "CreateGridBoxDialog"] to read MenuItem["&New...", "CreateGridBoxDialog", MenuKey["m", Modifiers-...
Post a Comment
Read more

How to thread a list

I have data in format data = {{a1, a2}, {b1, b2}, {c1, c2}, {d1, d2}} Tableform: I want to thread it to : tdata = {{{a1, b1}, {a2, b2}}, {{a1, c1}, {a2, c2}}, {{a1, d1}, {a2, d2}}} Tableform: And I would like to do better then pseudofunction[n_] := Transpose[{data2[[1]], data2[[n]]}]; SetAttributes[pseudofunction, Listable]; Range[2, 4] // pseudofunction Here is my benchmark data, where data3 is normal sample of real data. data3 = Drop[ExcelWorkBook[[Column1 ;; Column4]], None, 1]; data2 = {a #, b #, c #, d #} & /@ Range[1, 10^5]; data = RandomReal[{0, 1}, {10^6, 4}]; Here is my benchmark code kptnw[list_] := Transpose[{Table[First@#, {Length@# - 1}], Rest@#}, {3, 1, 2}] &@list kptnw2[list_] := Transpose[{ConstantArray[First@#, Length@# - 1], Rest@#}, {3, 1, 2}] &@list OleksandrR[list_] := Flatten[Outer[List, List@First[list], Rest[list], 1], {{2}, {1, 4}}] paradox2[list_] := Partition[Riffle[list[[1]], #], 2] & /@ Drop[list, 1] RM[list_] := FoldList[Transpose[{First@li...
Post a Comment
Read more

dynamic - How can I make a clickable ArrayPlot that returns input?

I would like to create a dynamic ArrayPlot so that the rectangles, when clicked, provide the input. Can I use ArrayPlot for this? Or is there something else I should have to use? Answer ArrayPlot is much more than just a simple array like Grid : it represents a ranged 2D dataset, and its visualization can be finetuned by options like DataReversed and DataRange . These features make it quite complicated to reproduce the same layout and order with Grid . Here I offer AnnotatedArrayPlot which comes in handy when your dataset is more than just a flat 2D array. The dynamic interface allows highlighting individual cells and possibly interacting with them. AnnotatedArrayPlot works the same way as ArrayPlot and accepts the same options plus Enabled , HighlightCoordinates , HighlightStyle and HighlightElementFunction . data = {{Missing["HasSomeMoreData"], GrayLevel[ 1], {RGBColor[0, 1, 1], RGBColor[0, 0, 1], GrayLevel[1]}, RGBColor[0, 1, 0]}, {GrayLevel[0], GrayLevel...
Post a Comment
Read more