Skip to main content

performance tuning - Fast Trial Division


I'm going to write a custom Trial Division primality test. I know that PrimeQ will first try trial division and then switches to PowerMod.


TrialFactorFreeQ[N_, Max_] := 
(For[j = 1, j < Max && Divisible[N, Prime[j]] == False, j++];
Return[j == Max])


For example for testing a 300K digits number with first 100,000 primes, it took 4 seconds which is very slow since a real testing is applied for billions of primes.


In[179]:= Timing[TrialFactorFreeQ[3^1000000 + 2, 100000]]

Out[179]= {4.031, True}

Can it be optimized?




I wrote the parallel version and its timing seems good but when I wrap it in a function, the timing goes to sky:


p = 3^1000000 + 2;
max = Prime[100000];


In[85]:= ParallelTrialFactorFreeQ[Num_, Maxi_] := (IsFree = True;
ParallelDo[
If[Divisible[Num, i], IsFree = False; Break[]], {i,
Prime[Range[1, PrimePi[Maxi]]]}] If[! IsFree, AbortKernels[]];
Return[IsFree])

In[82]:= AbsoluteTiming[ParallelTrialFactorFreeQ[p, max]]

Out[82]= {18.2821829, True}


In[84]:= Timing[Num = p; Maxi = max;
IsFree = True;
ParallelDo[
If[Divisible[Num, i], IsFree = False; Break[]],
{i,Prime[Range[1, PrimePi[Maxi]]]}];
If[! IsFree, AbortKernels[]]; IsFree]

Out[84]= {0.609, True}




Updated


Based on the Daniel Lichtblau answer to my Fast Sieve Implementation question, I wrote a very fast Trial Division function which can be used for numbers that are larger than products of primes in the given range:


prod = Product[i, {i, Prime[Range[10^5]]}];

TrialFactorFreeQ2[n_] := GCD[n, prod] == 1

And a 10x speedup


n = 3^1000000 + 2;


Timing[TrialFactorFreeQ2[n]]


{0.375, True}




Answer



For me


 SetAttributes[ParallelTrialFactorFreeQ, HoldAll]

does the trick and reduces the measured time your function needs to evaluate down to what you would expect.



Additionally I noticed that specifying the method used by ParallelDo brings down the timing slightly. By try and error i figured that Method -> "CoarsestGrained" works best on my machine. For other methods have a look in the documentation of Parallelize in the MORE INFORMATION- section. Code looks as follows:


p = 3^1000000 + 2;
maxIndex = 100000;

.


ParallelTrialFactorFreeQ[Num_, MaxIndex_] := (
IsFree = True;
ParallelDo[
If[Divisible[Num, i], IsFree = False; Break[]],
{i, Prime[Range[1, MaxIndex]]},

Method -> "CoarsestGrained"]
If[! IsFree, AbortKernels[]];
Return[IsFree])

.


SetAttributes[ParallelTrialFactorFreeQ, HoldAll]

.


AbsoluteTiming[ParallelTrialFactorFreeQ[p, maxIndex]]



{2.611613, True} (* First Run *)


{2.0153128, True} (* Second Run *)



Comments

Popular posts from this blog

plotting - Filling between two spheres in SphericalPlot3D

Manipulate[ SphericalPlot3D[{1, 2 - n}, {θ, 0, Pi}, {ϕ, 0, 1.5 Pi}, Mesh -> None, PlotPoints -> 15, PlotRange -> {-2.2, 2.2}], {n, 0, 1}] I cant' seem to be able to make a filling between two spheres. I've already tried the obvious Filling -> {1 -> {2}} but Mathematica doesn't seem to like that option. Is there any easy way around this or ... Answer There is no built-in filling in SphericalPlot3D . One option is to use ParametricPlot3D to draw the surfaces between the two shells: Manipulate[ Show[SphericalPlot3D[{1, 2 - n}, {θ, 0, Pi}, {ϕ, 0, 1.5 Pi}, PlotPoints -> 15, PlotRange -> {-2.2, 2.2}], ParametricPlot3D[{ r {Sin[t] Cos[1.5 Pi], Sin[t] Sin[1.5 Pi], Cos[t]}, r {Sin[t] Cos[0 Pi], Sin[t] Sin[0 Pi], Cos[t]}}, {r, 1, 2 - n}, {t, 0, Pi}, PlotStyle -> Yellow, Mesh -> {2, 15}]], {n, 0, 1}]

plotting - Plot 4D data with color as 4th dimension

I have a list of 4D data (x position, y position, amplitude, wavelength). I want to plot x, y, and amplitude on a 3D plot and have the color of the points correspond to the wavelength. I have seen many examples using functions to define color but my wavelength cannot be expressed by an analytic function. Is there a simple way to do this? Answer Here a another possible way to visualize 4D data: data = Flatten[Table[{x, y, x^2 + y^2, Sin[x - y]}, {x, -Pi, Pi,Pi/10}, {y,-Pi,Pi, Pi/10}], 1]; You can use the function Point along with VertexColors . Now the points are places using the first three elements and the color is determined by the fourth. In this case I used Hue, but you can use whatever you prefer. Graphics3D[ Point[data[[All, 1 ;; 3]], VertexColors -> Hue /@ data[[All, 4]]], Axes -> True, BoxRatios -> {1, 1, 1/GoldenRatio}]

plotting - Adding a thick curve to a regionplot

Suppose we have the following simple RegionPlot: f[x_] := 1 - x^2 g[x_] := 1 - 0.5 x^2 RegionPlot[{y < f[x], f[x] < y < g[x], y > g[x]}, {x, 0, 2}, {y, 0, 2}] Now I'm trying to change the curve defined by $y=g[x]$ into a thick black curve, while leaving all other boundaries in the plot unchanged. I've tried adding the region $y=g[x]$ and playing with the plotstyle, which didn't work, and I've tried BoundaryStyle, which changed all the boundaries in the plot. Now I'm kinda out of ideas... Any help would be appreciated! Answer With f[x_] := 1 - x^2 g[x_] := 1 - 0.5 x^2 You can use Epilog to add the thick line: RegionPlot[{y < f[x], f[x] < y < g[x], y > g[x]}, {x, 0, 2}, {y, 0, 2}, PlotPoints -> 50, Epilog -> (Plot[g[x], {x, 0, 2}, PlotStyle -> {Black, Thick}][[1]]), PlotStyle -> {Directive[Yellow, Opacity[0.4]], Directive[Pink, Opacity[0.4]],